Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omit empty tags in RunnerDeployment #16075

Merged
merged 1 commit into from
Nov 21, 2024
Merged

omit empty tags in RunnerDeployment #16075

merged 1 commit into from
Nov 21, 2024

Conversation

zzstoatzz
Copy link
Collaborator

closes #16074

@github-actions github-actions bot added the enhancement An improvement of an existing feature label Nov 20, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 20, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #16075 will not alter performance

Comparing omit-empty-tags (00c3fc8) with main (ad9db06)

Summary

✅ 3 untouched benchmarks

@github-actions github-actions bot added the docs label Nov 20, 2024
zzstoatzz
zzstoatzz commented Nov 20, 2024
View reviewed changes
docs/v3/api-ref/rest-api/server/schema.json Outdated
Copy link
Collaborator Author

@zzstoatzz zzstoatzz Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some version got bumped here, its just all "title": "Foo " -> "title": "Foo"

desertaxle
desertaxle approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zzstoatzz zzstoatzz merged commit 78ee41c into main Nov 21, 2024
36 checks passed
@zzstoatzz zzstoatzz deleted the omit-empty-tags branch November 21, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@discdiver discdiver Awaiting requested review from discdiver

Assignees
No one assigned
Labels
docs enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dont add empty tags
2 participants
@zzstoatzz @desertaxle