feat(Deployments): support Job Variables #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpelletier
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
|
This is great, thanks for your contribution @felixpelletier! Will take a look 👍🏼 |
The 'env' key is "the only job variable that is configurable for all work pool types" (https://docs.prefect.io/latest/guides/deployment/overriding-job-variables/) so let's use that as the example and as the test to confirm it works as expected.
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
|
Hi @felixpelletier, I pushed one small change 309ab47. I found that |
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
mitchnielsen
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
This looks great, thanks again @felixpelletier 🎉
- New field added in correct places
- Tests added and passing
- Docs updated
Will approve and hand to @parkedwards for a final lookover since I ended up pushing a couple small changes.
parkedwards
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Supports setting Job Variables on Deployment resources.
Related to #238
Note: I'm a Go newbie, but I mainly just followed the very similar PR here: #245
Testing
I ran the unit tests, but I don't have an appropriate setup to run the acceptance tests.
If someone could help with that, I'd be very grateful 😉