Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pagination/scroll behavior on Reader #1184

Open
boonebgorges opened this issue Aug 21, 2024 · 0 comments
Open

Improve pagination/scroll behavior on Reader #1184

boonebgorges opened this issue Aug 21, 2024 · 0 comments
Labels
enhancement Reader
Milestone
5.8.0

Comments

@boonebgorges
Copy link
Contributor

Pagination and infinite scroll behavior on the Reader interface is buggy and inconsistent. Some notes:

  • On All Content, 20 items are loaded by default. On screen widths where the grid is 3 items wide, this creates a partial row at the bottom. This feels confusing.
  • Infinite Scroll seems to be broken on All Content grid view - no additional query is being triggered when reaching the end of the list
  • When using 'Paginate' mode on All Content, the 'Next Page' link is broken. Instead of going to ?page=pf-all-content, it goes to ?page=pf-menu

Let's do an audit of how pagination/scroll works, so that the experience is smoother and less buggy across Nominated and All Content.
@boonebgorges boonebgorges added this to the 5.8.0 milestone Aug 21, 2024
@boonebgorges boonebgorges mentioned this issue Aug 21, 2024
Open
boonebgorges added a commit that referenced this issue Nov 7, 2024
@boonebgorges
Fix pagination links for Feed Items.
7ef2a28 
They were broken when the 'pf-menu' slug was repurposed for the
new Dashboard landing page.

See #1184.
boonebgorges added a commit that referenced this issue Nov 7, 2024
@boonebgorges
Use 24 for the default per-page count on Feed Items.
48c8f9e 
24 has 2, 3, and 4 as a factor, so works well for various numbers of
columns.

See #1184.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Reader
Projects
None yet
Milestone
5.8.0
Development

No branches or pull requests
1 participant
@boonebgorges