Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing/Incorrect CSS for div "carrier-extra-content" - hook "displayCarrierExtraContent" #37194

Closed
2 tasks done
ShaiMagal opened this issue Oct 19, 2024 · 2 comments · Fixed by PrestaShop/classic-theme#157
Closed
2 tasks done
Labels
9.0.x Branch FO Category: Front Office Hook Improvement Type: Improvement Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Shopping carts FO All the issues related to the Front Office Shopping Cart Verified The issue has been reproduced

Comments

@ShaiMagal
Copy link
Contributor

ShaiMagal commented Oct 19, 2024

Prerequisites

Describe the bug and add attachments

If any module add text to "carrier-extra-content" via hook "displayCarrierExtraContent", it's not stylled properly. Especially on mobile, it's broken. Check screenshot.
3 problems:
A) it's not aligned properly (because missing "margin: auto;" like for element "delivery-option")
B) unnecessary (not connected) dash to the right
C) it is not indented from the bottom, then it looks like part of the note.
Untitled

Expected behavior

It must be aligned and working well. There is more options how to fix, but I am not front end developer.

Maybe @tblivet is a suitable candidate for fix (PR)? :)

Steps to reproduce

  1. open website https://demo.prestashop.com/#/en/front and click click click to order section "3" - shipping method
  2. open JS konzole (F12)
  3. fill there "$('.carrier-extra-content').text('Lorem ipsum dolor sit amet.');" and press enter
  4. you will see results

You can make module for this purpose as well, but this is faster and easier.

PrestaShop version(s) where the bug happened

8.2.0

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

No response

Your company or customer's name goes here (if applicable).

https://www.openservis.cz/

@ShaiMagal ShaiMagal added Bug Type: Bug New New issue not yet processed by QA Improvement Type: Improvement FO Category: Front Office and removed Bug Type: Bug labels Oct 19, 2024
@florine2623
Copy link
Contributor

Hello @ShaiMagal ,

I have reproduced your issue with PS 8.2.0 and 9.0.x, I'll add this to the backlog so it can be fixed.

Screenshot 2024-10-21 at 13 53 55

Please be aware that some issues might take a very long time to be resolved. If this one is important to you and you cannot wait for it to be fixed on the project’s own time, we strongly suggest you consider contacting a professional to help you.

If you fix the issue on your end, please contribute it back to the project. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you

@florine2623 florine2623 added Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Ready Status: Issue is ready to be worked on Shopping carts FO All the issues related to the Front Office Shopping Cart Hook Verified The issue has been reproduced 9.0.x Branch and removed New New issue not yet processed by QA labels Oct 21, 2024
@tblivet tblivet linked a pull request Oct 22, 2024 that will close this issue
@ShaiMagal
Copy link
Contributor Author

Fixed already by PrestaShop/classic-theme#157, so closing :) Thanks @tblivet

@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0.x Branch FO Category: Front Office Hook Improvement Type: Improvement Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Shopping carts FO All the issues related to the Front Office Shopping Cart Verified The issue has been reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants