Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing width and height to image on Product Pack #136

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Added missing width and height to image on Product Pack #136

merged 2 commits into from
Feb 6, 2024

Conversation

buggyzap
Copy link
Contributor

Questions Answers
Description? I have added missing attribute width and height to product pack miniature to prevent CLS and improve Web Vitals
Type? improvement
BC breaks? no
Deprecations? no

mflasquin
mflasquin approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@mflasquin mflasquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Jan 31, 2024
@paulnoelcholot
Copy link

@PrestaShop/product-council need an approval to take it 🙏

@Hlavtox
Copy link
Contributor

Hlavtox commented Feb 6, 2024

@paulnoelcholot There is nothing to approve. :-)

@MatShir MatShir added Waiting for author and removed Waiting for QA Status: Waiting for QA feedback labels Feb 6, 2024
@MatShir
Copy link

MatShir commented Feb 6, 2024

Hey @Hlavtox,
Normally improvement need to be checked by @PrestaShop/product-council 🤔
Is your comment a request of changes or we can move forward in the PR testing ?

@Hlavtox
Copy link
Contributor

Hlavtox commented Feb 6, 2024

@MatShir
A) It's not a product thing, it's just a technical change, no visual change.
B) I checked it.
C) The PR has a tiny issue, that's why I proposed a change.

@buggyzap buggyzap requested a review from Hlavtox February 6, 2024 11:59
@Hlavtox Hlavtox added this to the 2.1.3 milestone Feb 6, 2024
@Hlavtox Hlavtox merged commit 5ad791f into PrestaShop:develop Feb 6, 2024
6 checks passed
@Hlavtox Hlavtox modified the milestones: 2.1.3, 3.0.0 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflasquin mflasquin mflasquin approved these changes

@Hlavtox Hlavtox Hlavtox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@buggyzap @paulnoelcholot @Hlavtox @MatShir @mflasquin @ps-jarvis