Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite demoextendsymfonyform1 module without CQRS #35

Merged
merged 5 commits into from
Feb 2, 2021

Conversation

matks
Copy link
Contributor

@matks matks commented Jan 18, 2021

Questions Answers
Description? There is confusion about Demo Symfony Form module 1 because the module demonstrates 2 things: how to use a CQRS in a module AND how to use hooks to add new field to a Symfony form

Some community developers think that the two must be together although actually you can choose to use CQRS or not to add new field to a Symfony form.

To fix this I will split this module into 2 demo modules. This PR rewrites the module without CQRS.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes 1 item of #32
How to test? Test module works fine as before.
Possible impacts?

Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small feedback

@matks matks merged commit 6d1f35f into PrestaShop:master Feb 2, 2021
@matks matks deleted the split-module-2 branch February 2, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants