Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add new adress with hummingbird theme #441

Closed
sudo-do opened this issue Jan 27, 2023 · 7 comments
Closed

Can't add new adress with hummingbird theme #441

sudo-do opened this issue Jan 27, 2023 · 7 comments

Comments

@sudo-do
Copy link
Contributor

sudo-do commented Jan 27, 2023

Problem is when write address information and continue to shipping carrier selection, it just reloads and asking the adress information again.
I tried on fresh prestashop with current develop branch.

bandicam.2023-01-27.21-56-02-335.mp4

||Red text in end saying "No suitable carrier for your location", its ok||

@sudo-do
Copy link
Contributor Author

sudo-do commented Jan 27, 2023

I just saw this commit and what i did was just reversing it, I don't think this issue is easy to fix as i thought.
d26f38c

@Hlavtox
Copy link
Contributor

Hlavtox commented Jan 27, 2023

@nizelg Yes, I found this also few days ago (added here #409). I also can't add a new address for some reason in my account section, not sure what is happening. 🤷

@TheGera
Copy link

TheGera commented Jan 28, 2023

The problem happened when 418 I ignored changes in theme.js and the addresses work

@sudo-do
Copy link
Contributor Author

sudo-do commented Jan 28, 2023

I confirm that problem is theme.ts in 418 Thank you TheGera

@Hlavtox
Copy link
Contributor

Hlavtox commented Jan 28, 2023

@NeOMakinG Bro do you think you could check this? We need to revert that token change or improve it, like @nizelg done. 😞 It broke address forms.

BTW, @nizelg, these buttons can also be on product pages in accessories, in crosselling on shopping cart page etc. We must do it properly. 😛

@sudo-do
Copy link
Contributor Author

sudo-do commented Jan 28, 2023

I've been casually browsing the site and adding items to my cart, and it seems to be working fine. I was cleared my cache, the issue seems fixed

bandicam.2023-01-28.17-08-25-021.mp4

@Hlavtox
Copy link
Contributor

Hlavtox commented Jan 31, 2023

Fixed

@Hlavtox Hlavtox closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants