Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The imported logo is displayed in its original width/height #479

Closed
hibatallahAouadni opened this issue Mar 30, 2023 · 3 comments
Closed

The imported logo is displayed in its original width/height #479

hibatallahAouadni opened this issue Mar 30, 2023 · 3 comments
Labels
Bug Something isn't working Home Page Verified The issue has been reproduced

Comments

@hibatallahAouadni
Copy link

Describe the bug

The imported logo is displayed in its original width/height while with Classic theme, the logo is displayed responsive.

Expected behavior

The imported logo should respect the width/height of header and be responsive.

Steps to reproduce

  1. BO>DESIGN>Theme & Logo
  2. Import a new large logo
  3. Save
  4. Access to FO
  5. See error > the logo is displayed with its original width/height, making the header looks bigger ❌

Screenshots
image

Additional infos

  • PS version: 8.0.0 & 8.0.3
  • PHP version: 7.3
  • HummingBird version: 0.1.5
@hibatallahAouadni hibatallahAouadni added Bug Something isn't working Home Page labels Mar 30, 2023
@sudo-do
Copy link
Contributor

sudo-do commented Mar 30, 2023 •
edited
Loading

The imported logo should respect the width/height of header and be responsive.

+ Imported logo have it's own size as width/height attribute

@florine2623 florine2623 added the Verified The issue has been reproduced label Mar 29, 2024
@nicosomb nicosomb mentioned this issue May 16, 2024
Open
28 tasks
@tblivet
Copy link
Contributor

tblivet commented May 20, 2024

Hi @nicosomb, this issue seems to be corrected by this PR: #606

@nicosomb
Copy link
Contributor

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Home Page Verified The issue has been reproduced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nicosomb @florine2623 @hibatallahAouadni @sudo-do @tblivet