Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add Node.js toolkit support #36

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Conversation

jokesterfr
Copy link
Contributor

@jokesterfr jokesterfr commented Dec 4, 2023

Description

  • Add Node.js support
    • npm
    • pnpm
    • yarn
  • PLATFORM becomes an alias of TARGETPLATFORM

How to test

$ PLATFORM=linux/arm64 ./build.sh
❯ docker run -it --rm --entrypoint sh prestashop/prestashop-flashlight:latest
/var/www/html # node -v
v16.16.0
/var/www/html # npm -v
8.11.0
/var/www/html # yarn -v
1.22.21
/var/www/html # pnpm -v
8.11.0

Warnings

  • PS 1.6 does not require Node.js, and this is better like this because the old Alpine image provided by PHP cannot really ship it correctly (Alpine + ARM64 at least).

@jokesterfr jokesterfr self-assigned this Dec 4, 2023
@jokesterfr jokesterfr force-pushed the feat/add-nodejs-support branch 2 times, most recently from 9326ff2 to e28d432 Compare December 4, 2023 16:44
@jokesterfr jokesterfr force-pushed the feat/add-nodejs-support branch from d21166c to 39da558 Compare December 4, 2023 21:32
@jokesterfr jokesterfr merged commit d0c546b into main Dec 5, 2023
8 checks passed
@jokesterfr jokesterfr deleted the feat/add-nodejs-support branch December 5, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants