-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buttons: white text on cyan background fails the simplest contrast test (WCAG:AA) #155
Comments
@PrestaShop/prestashop-core-developers is it just a CSS property ? |
Hello @ldeprestashop yes, the settings being discussed here are related to CSS. However changing CSS values is not a decision we can make alone. These colors have been chosen to follow PrestaShop brand identity. |
OK thanks :) I will meet Thibaut this afternoon to discuss about that. |
Hello everyone, Thanks @tdupre for this issue 🙂 We know that the current color In fact, we did a color test with the We didn't test the See the screenshot from this website: Se we tried See the screenshot from this website: You can see the color test on the Figma file. Let me know what you think ✌️ |
Hi there, I'm Guillaume, product designer of PS Metrics, is that could help, you can see in this file our interface with buttons as purple color @prestascott we have a purple a little darker than your proposal, tell me what you think about this one : 34219E (who is the same as the logo of Prestashop), thanks! |
Hey @gsauvanon-presta 👋🏻 Thanks for your response. The purple color used I need to use a 600-level maximum in order to use higher levels for events such as Hover and Pressed. If the primary color is too dark, it will be difficult to differentiate Hover status than Default status 😅 |
hey @prestascott thanks for your advice, sounds great to use #5434d0, I understand that our purple is too dark 😈 |
Readability and accessibility
Readability and accessibility are paramount these days and companies get fined for not complying with accessibility basic rules (in the US and soon in Europe)
Acccessibility issue
The buttons used in PrestaShop UI kit fail the simplest contrast test (WCAG:AA) Foreground:#FFFFFF background:#2eb9d7
https://color.a11y.com/ContrastPair/?bgcolor=2eb9d7&fgcolor=ffffff
Fix proposition
One way to fix this would be to use the purple that's available in PrestaShop's colors #442CC7 ensuring a good contrast between the text and the background
https://color.a11y.com/ContrastPair/?bgcolor=442CC7&fgcolor=ffffff
The text was updated successfully, but these errors were encountered: