Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: size of the invalid state #213

Open
amaury-hanser opened this issue Feb 7, 2023 · 1 comment
Open

Enhancement: size of the invalid state #213

amaury-hanser opened this issue Feb 7, 2023 · 1 comment

Comments

@amaury-hanser
Copy link
Contributor

Hello,

I suggest to increase the font-size of the validation message.
For now, the font-size compute to 10px.

It comes from the mixin @mixin ps-form-validation-state($state, $color) in scss/mixins/_forms.scss

@mixin ps-form-validation-state($state, $color) {
  .form-control.is-#{$state},
  .is-#{$state} {
    border-color: $color;

    &:focus {
      box-shadow: none;
    }
  }

  .#{$state}-feedback {
    margin-top: 0.3125rem;
    font-size: $font-size-xs;
    font-weight: $font-weight-bold;
    color: $color;
  }
}

The variable $font-size-xs is defined in scss/_variables.scss:
The value is:

$font-size-xs: 0.625rem; // PS custom

What do you think about increasing the computed value to 12px instead?

@prestascott
Copy link

I agree with @amaury-hanser, 10px is very small and difficult to read for users.
The minimum size is 14px but it's not the case in the back office.
Size 12px seems to be good according to the back office.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants