Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional dependencies tied to PS versions #7

Open
sowbiba opened this issue Nov 10, 2023 · 1 comment
Open

Optional dependencies tied to PS versions #7

sowbiba opened this issue Nov 10, 2023 · 1 comment

Comments

@sowbiba
Copy link
Contributor

sowbiba commented Nov 10, 2023

As discussed during the Architecture Guild I see two interesting things that could be added (not necesarily for a preliminary version):

  • Dependencies tied to specific PS version:

A real example can be PS Accounts which depends on PS EventBus for 1.7 on ahead but for 1.6.x (In fact PS EventBus doesn't exists in 1.6). We could have some scenarios in the future.

  • Optional dependencies:

We could have an scenario where a module is compatible with another modules and can be integrated. I can imagine an scenario where PS Checkout is compatible with some delivery module and hence be an optional dependency to be suggested during the module check.

Great work!

Originally posted by @Rzial in https://github.com/PrestaShopCorp/ADR-Architecture-Decision-Records/issues/35#issuecomment-1802006822

@sowbiba
Copy link
Contributor Author

sowbiba commented Nov 10, 2023

Thanks @Rzial

We can imagine a structure like this

{
    "dependencies": [
      {
        "name" : "ps_accounts",
         "ps_min_version" : "1.7.0",
         "ps_max_version" : "8.1.0"
      },
      {
        "name" : "ps_eventbus"
      }
    ]
}

If ps_min_version and ps_max_version are specified, if the shop version is not between these 2 values, the dependency will be ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant