forked from PrestaShop/docker
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): New system #1
Draft
Venatum
wants to merge
29
commits into
master
Choose a base branch
from
fea/docker-next
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vincent Le Quec <[email protected]>
Co-authored-by: Vincent Le Quec <[email protected]>
The build process for creating the Docker image for Prestashop has been significantly restructured. This change was due to the necessity to support different PHP versions, OS flavours, and server types, which all affected the creation of the Docker images. Thus, build.sh was updated to get PHP version and flavour based on the Prestashop version and considered OS and server types. Also, all the json files that were used to get info for build.sh and were not relevant anymore were removed. In addition, the Github workflows have been updated to work with the new build process structure. Also, Dockerfile names have been simplified removing '-base' from the names.
jokesterfr
requested changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove ./images and ./old from the changes ;)
jokesterfr
approved these changes
Jun 24, 2024
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 New docker image system
Improve docker image build & add arm support
📦 What's in the box?
🤖 How to test it?
fea/docker-next
./build.sh
🎉 Links useful