Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): New system #1

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

feat(docker): New system #1

wants to merge 29 commits into from

Conversation

Venatum
Copy link
Collaborator

@Venatum Venatum commented Nov 24, 2023

🚀 New docker image system

Improve docker image build & add arm support

📦 What's in the box?

  • Docker image
    • Debian
      • Build
        • fpm
        • nginx
        • apache
      • Test / Run
    • Alpine
      • Build
        • fpm
        • nginx
        • apache
      • Test / Run
    • Nightly
      • Build
        • fpm
        • nginx
        • apache
      • Test / Run
  • Clean repo
  • CI tests
    • Test x86_64 build
    • Test arm64 build
    • Lint sh
    • Lint docker (hadolint)
    • Basic run, prestashop should be healthy with the basic demo example
      • Can use also nc to check the port, or curl the robots.txt file
  • Examples
  • Documentation
  • Enlever les droits root ?
  • Fix shellscript linting on legacy ./assets/docker_run.sh
  • Gestion des tags
  • Voir pour Presta 9...

Que faire de PHP_CMD ?

🤖 How to test it?

  • Checkout the fea/docker-next
  • ./build.sh
  • Enjoy the landscape?

🎉 Links useful

jokesterfr and others added 10 commits April 7, 2023 15:03
Co-authored-by: Vincent Le Quec <[email protected]>
Co-authored-by: Vincent Le Quec <[email protected]>
The build process for creating the Docker image for Prestashop has been significantly restructured. This change was due to the necessity to support different PHP versions, OS flavours, and server types, which all affected the creation of the Docker images. Thus, build.sh was updated to get PHP version and flavour based on the Prestashop version and considered OS and server types. Also, all the json files that were used to get info for build.sh and were not relevant anymore were removed.

In addition, the Github workflows have been updated to work with the new build process structure. Also, Dockerfile names have been simplified removing '-base' from the names.
@Venatum Venatum added the enhancement Type: Improvement label Nov 24, 2023
Copy link
Collaborator

@jokesterfr jokesterfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ./images and ./old from the changes ;)

@Venatum Venatum marked this pull request as draft December 13, 2023 15:44
@jokesterfr jokesterfr self-requested a review March 8, 2024 16:39
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8 Security Hotspots

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants