Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] [Snackbar] Add a success state #205

Closed
1 of 7 tasks
mattgoud opened this issue Oct 4, 2023 · 0 comments · Fixed by #206
Closed
1 of 7 tasks

[Design] [Snackbar] Add a success state #205

mattgoud opened this issue Oct 4, 2023 · 0 comments · Fixed by #206
Assignees
Labels
enhancement New feature or request

Comments

@mattgoud
Copy link
Collaborator

mattgoud commented Oct 4, 2023

Is there an existing issue for this ?

  • I have searched the existing issues

Current Behavior

no version for snackbar success

Expected Behavior

Add a success state and style

Anything else?

Default

The snackbar default is the neutral version of the component. It should be used to inform users of a common action done by them which not fit in any of the other variants (e.g. link copied, files archived, etc).

Success

The snackbar success variant should be used to inform users about an important successful action or upon completion of a task (e.g. elements saved or updated).

Design Checklist

  • Layers named in alignment with component guidelines
  • Accessible use of color and sufficient touch target area
  • All interactive states accounted for
  • Supported variant options included
  • Relevant variants like sizing, styles, icons, error states, etc are included in components. Please note in review request if any currently supported variants are intentionally excluded or removed.
  • Adding or updating information about the component in the properties panel. Include link to any documentation if it currently exists.
@mattgoud mattgoud added the enhancement New feature or request label Oct 4, 2023
@mattgoud mattgoud self-assigned this Oct 4, 2023
mattgoud added a commit that referenced this issue Oct 4, 2023
@mattgoud mattgoud linked a pull request Oct 4, 2023 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant