Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pagination] [Loader variant] - refacto itemCount #344

Closed
mattgoud opened this issue Jun 17, 2024 · 0 comments · Fixed by #345
Closed

[Pagination] [Loader variant] - refacto itemCount #344

mattgoud opened this issue Jun 17, 2024 · 0 comments · Fixed by #345
Assignees
@mattgoud
Labels
Feature Type: New Feature

Comments

@mattgoud
Copy link
Collaborator

Context

Pagination variant loader

Currently the number of items seen must be implemented by the user via the itemCount prop. This should be managed automatically at the internal level of the component.
@mattgoud mattgoud self-assigned this Jun 17, 2024
@mattgoud mattgoud added the Feature Type: New Feature label Jun 17, 2024
mattgoud added a commit that referenced this issue Jun 17, 2024
@mattgoud
feat: related #344 - refacto item count (wip)
188f276
@mattgoud mattgoud linked a pull request Jun 17, 2024 that will close this issue
feat: related #344 - handle items count and loader btn behaviors internally #345
Merged
9 tasks
mattgoud added a commit that referenced this issue Jun 19, 2024
@mattgoud
Merge pull request #345 from PrestaShopCorp/344-pagination-loader-var…
565a49b 
…iant-refacto-itemcount

fix #344 - handle items count and loader btn behaviors internally
BC - remove itemCount and ButtonDisabled prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattgoud mattgoud

Labels
Feature Type: New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: related #344 - handle items count and loader btn behaviors internally PrestaShopCorp/puik
1 participant
@mattgoud