Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Port to matchmaking rewrite #9

Closed
1 task done
ashquarky opened this issue Sep 28, 2024 · 1 comment · Fixed by #10
Closed
1 task done

[Enhancement]: Port to matchmaking rewrite #9

ashquarky opened this issue Sep 28, 2024 · 1 comment · Fixed by #10
Labels
approved The topic is approved by a developer enhancement An update to an existing part of the codebase

Comments

@ashquarky
Copy link
Member

Checked Existing

  • I have checked the repository for duplicate issues.

What enhancement would you like to see?

Dani has been hard at work at a complete rewrite of the matchmaking code in nex-protocols-common-go. It uses a Postgres database for room state, eliminating race conditions and state inconsistencies (we hope) - it also correctly implements more NEX notification types, including those needed for Splatfest matchmaking. We also expect to see moderation improvements from examining the database.

It'd be nice to bring these improvements to Splatoon.

Any other details to share? (OPTIONAL)

Some experimental work has happened in Minecraft: https://github.com/PretendoNetwork/minecraft-wiiu/tree/work/mm-rewrite

External contributors please note that the matchmaking rewrite is not final and may not be merged in its current state. Consider this experimental work to see if the improvements stick, which may be dropped from no fault of your own. Don't expect a merge into the main Splatoon branch until the matchmaking-rewrite also merges, but we'd love to experiment with such a build in the meantime.

@ashquarky ashquarky added enhancement An update to an existing part of the codebase awaiting-approval Topic has not been approved or denied labels Sep 28, 2024
@AToska21
Copy link
Contributor

I'm working on a build of the splatoon server with this rewrite, will update here and make a pull request when it's ready.

@jonbarrow jonbarrow added approved The topic is approved by a developer and removed awaiting-approval Topic has not been approved or denied labels Sep 30, 2024
@jonbarrow jonbarrow moved this to In Progress in Pretendo Tasks and Goals Sep 30, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Pretendo Tasks and Goals Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The topic is approved by a developer enhancement An update to an existing part of the codebase
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants