Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Balancer's MerkleOrchard over MerkleDrop.sol #216

Open
TomAFrench opened this issue Nov 1, 2021 · 1 comment
Open

Consider using Balancer's MerkleOrchard over MerkleDrop.sol #216

TomAFrench opened this issue Nov 1, 2021 · 1 comment

Comments

@TomAFrench
Copy link

I noticed that you're using a merkle drop contract for repeated distributions of the same token. At Balancer we've got a version of this which has been gas optimised for people claiming multiple distributions to massively reduce the number of SSTOREs needed.

The only downsides I see is that we don't support zeroing out merkle roots after the fact (expireTranche) and if you're going to be making distributions from multiple addresses then you'll need a thin wrapper contract in front to ensure each distribution goes in the same "distribution channel".

If those aren't dealbreakers though you'd benefit from being able to claim distributions more cheaply, claiming in parallel with other tokens and easy integration with Balancer UI, etc.

@fabianschu
Copy link
Contributor

@TomAFrench Thanks for the initiative. What you're saying sounds very suitable to what we need. I'll look into MerkleOrchard :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants