Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Remove useless code #144

Open
bxmmm1 opened this issue Jul 4, 2022 · 0 comments · May be fixed by #172
Open

Chore: Remove useless code #144

bxmmm1 opened this issue Jul 4, 2022 · 0 comments · May be fixed by #172

Comments

@bxmmm1
Copy link
Contributor

bxmmm1 commented Jul 4, 2022

Status quo

At the moment our RewardFactory has some function related to keeping track of active rewards. But from what I see, that is related to ExtraRewardStashV2 and it is not used in our version that only supports ExtraRewardStashV3. Investigate, and remove if it is unused

To do

Remove useless code from RewardFactory related to rewardActiveList
@bxmmm1 bxmmm1 changed the title Remove useless code Chore: Remove useless code Jul 4, 2022
@bxmmm1 bxmmm1 linked a pull request Jul 5, 2022 that will close this issue
Remove useless code from RewardFactory #172
Open
@bxmmm1 bxmmm1 mentioned this issue Jul 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove useless code from RewardFactory PrimeDAO/pools-contracts
1 participant
@bxmmm1