Remove useless code from RewardFactory #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 86.83% 86.32% -0.51%
==========================================
Files 13 13
Lines 676 651 -25
Branches 87 82 -5
==========================================
- Hits 587 562 -25
Misses 89 89
Continue to review full report at Codecov.
|
BritikovKI
reviewed
Jul 7, 2022
| @@ -10,8 +10,6 @@ import "../utils/MathUtil.sol"; | |||
| contract RewardFactory is IRewardFactory { | |||
| using MathUtil for uint256; | |||
|
|
|||
| event ExtraRewardAdded(address reward, uint256 pid); | |||
There was a problem hiding this comment.
Hmm, why do you think this code is not going to be used?
There was a problem hiding this comment.
It is related to ExtraRewardStashV2, and we are using v3, which doesn't need this anymore. And it is not used anywhere
…hore-remove-useless-code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.