Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Celo Network (Alfajores + Mainnet) #759

Open
5 of 7 tasks
hiaux0 opened this issue Aug 30, 2022 · 1 comment
Open
5 of 7 tasks

Add Celo Network (Alfajores + Mainnet) #759

hiaux0 opened this issue Aug 30, 2022 · 1 comment
Assignees
Labels

Comments

@hiaux0
Copy link
Contributor

hiaux0 commented Aug 30, 2022

Decide which approach

  1. Different URL (via env variables)
  2. Network Dropdown (via localhost)

TODO

  • Should support 4 networks?
    • Favorit: Only show mainnet on prod (testnet on dev/staging
      • because, that's current approach (eg. Gnosis shows all, but we don't want to follow)
  • Based on decision add Steps to repro for Bartu
  • Make sure you can read from the Celo chain
  • Make sure we can interact with the Celo chain (how to make sure?
  • Coingecko, make sure prices are taken from Celo and not Ethereum
  • Generally, ensure everything works like on Ethereum

Approach

  1. just add dropdown with 4 networks (without diffrentiating)
  2. ask about celo safe and alfajores -> Celo Safe not on Alfajores
@hiaux0 hiaux0 transferred this issue from PrimeDAO/contracts Aug 30, 2022
@hiaux0 hiaux0 added the Seed V1 label Aug 31, 2022
@hiaux0 hiaux0 changed the title Add Celo Testnet (Alfajores) Add Celo Network (Alfajores + Mainnet) Sep 2, 2022
@giladt
Copy link
Contributor

giladt commented Sep 6, 2022

What has been done:

  • Added Dropdown for:
    Production environment: Mainnet and Celo (Arbitrum is out of scope for this ticket).
    Development environment: Rinkeby and Alfajores.
  • Updated the Token-list for Alfajores in primeAlfajoresPayment
    Celo Token list has been already added by Eugene.
    These token lists are used for propagating the tokens dropdowns in the dApp (wizard, dashboard, etc.).
  • Updated Celo and Alfajores contracts to the latest exports from Contracts-V2

For Testing:

The first (clean) load should show either Mainnet or Rinkeby. After selecting a different network from the dropdown, a local-storage item would be set to save the user's selection for the next app load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants