-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code #133
base: main
Are you sure you want to change the base?
Update code #133
Conversation
update code and optimize and fix small bugs
improved code, optimized and shrunk by 10%
I browsed the changes briefly but please do me a favor. Could you run Thanks! |
image: undefined, | ||
title: null, | ||
inventory: null, | ||
image: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please tell me whether this makes any difference or the reason this was changed.
The current code changes seem to be rewritten for conciseness, no? If there's any bug fixes, can you point out where they are? From what I've gathered:
While I totally agree your changes do make the code easier to read and follow, there are reasons for structuring/writing it the way I did. I wanted to be clear about what the code does and what the program is doing when launched (for debugging and newbie purposes). It didn't make sense to me to import all modules if an environment file is not found. As for However, I will incorporate some of your changes like using arrow functions inside |
Small updates to improve code, fix small bugs, better readability