Acoustic surface #94
Merged
Acoustic surface #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Free surfaces in acoustic domains require a dirichlet BC on pressure. - The implementation provided in this commit implements the general case of dirichlet boundary condition for any type of element. In particular, for now we only implement hard wall BCs - The boundary conditions are implemeted as template parameter on an element. This should improve modularity when implementing other BCs, as long as BCs have same interfaces. - Implemeted routines for reading acoustic free surfaces from mesh database and generating a compute interface for the same. The boundary conditions are enforces in the compute_forces kernel in contradiction to the fortran code where BCs are enforced in subsequent CUDA kernels.
- There are minor changes from previous commit. - Key change includes elements on corner of domain or elements that have more than one edge / node on a free surface. To account for this I added a boundary_types struct to tag which node/edge is on the boundary for every element on the boundary. - Another change includes how elements on the boundary are tagged inside kernel and an explicit assertion that checks if the order of elements matches the one in compute::boundaries - Performance is similar to the one in devel branch (optimal performance).
- Moved array type to kokkos abstractions - Boundary conditions interface now takes partial derivatives and element properties structs as inputs during calculations. This is needed for more complicated BCs that depend on element shape and material propetrties. - Moved specfem::enums::coupling::type::edge -> specfem::enums::edge::type
- Implements Stacey BC as a separate class - GLL weights are passed as parameter to BC class
Major changes since previous commit - I had to add compute time mass matrix terms to account for modification on mass matrix at the boundary when using the Newmark timescheme - These contributions are added using mass_time_contribution function in the BC classes - The function is templated on type of timescheme and specialized implementation should exist when a contribution is required
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements dirichlet and stacey BCs.
Implementation details
Changes and reorganizations
Issue Number
If there is an issue created for these changes, link it here
Checklist
Please make sure to check developer documentation on specfem docs.