Address PR comments

PrismLibrary · Aug 27, 2024 · 6a44b06 · 6a44b06
1 parent f9ccc68
commit 6a44b06
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/Maui/Prism.Maui/Ioc/ContainerProvider.cs b/src/Maui/Prism.Maui/Ioc/ContainerProvider.cs
@@ -1,3 +1,4 @@
+#nullable enable
 namespace Prism.IoC;
 
 /// <summary>
@@ -9,8 +10,9 @@ namespace Prism.IoC;
 /// <code>
 /// public class MyValueConverter : IValueConverter
 /// {
-///     private ILoggerFacade _logger { get; }
-///     public MyValueConverter(ILoggerFacade logger)
+///     private readonly ILogger _logger { get; }
+///     
+///     public MyValueConverter(ILogger logger)
 ///     {
 ///         _logger = logger;
 ///     }
@@ -45,7 +47,7 @@ public class ContainerProvider<T>
     /// <summary>
     /// The Name used to register the type with the Container
     /// </summary>
-    public string Name { get; set; }
+    public string? Name { get; set; }
 
     /// <summary>
     /// Resolves the specified type from the Application's Container

diff --git a/tests/Maui/Prism.DryIoc.Maui.Tests/Prism.DryIoc.Maui.Tests.csproj b/tests/Maui/Prism.DryIoc.Maui.Tests/Prism.DryIoc.Maui.Tests.csproj
@@ -32,10 +32,4 @@
     <ProjectReference Include="..\..\..\src\Maui\Prism.Maui.Rx\Prism.Maui.Rx.csproj" />
   </ItemGroup>
 
-  <ItemGroup>
-    <MauiXaml Update="Mocks\Views\MockXamlView.xaml">
-      <Generator>MSBuild:Compile</Generator>
-    </MauiXaml>
-  </ItemGroup>
-
 </Project>