Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloseDialog to IDialogService or Extension Method #3171

Open
ramtechjoe opened this issue Jun 20, 2024 · 0 comments
Open

Add CloseDialog to IDialogService or Extension Method #3171

ramtechjoe opened this issue Jun 20, 2024 · 0 comments
Labels
Commercial Plus 🚀 Issue or Pull Request opened by a Commercial Plus license holder Core enhancement
Milestone

Comments

@ramtechjoe
Copy link

Summary

When using the IDialogService for popups sometimes one might want to be able to close the View from the ViewModel that made the ShowDialog call. In the old NavigationService based Popup framework you could call GoBackAsync to achieve this behavior. This does not exist in the IDialogService.

API Changes

An extension method could potentially be added to IDialogService with a close method.

Intended Use Case

In our existing Xamarin Forms app we have several long running processes. To improve the user experience we have a Popup that displays a busy indicator and a message describing the on-going operation. This was easy to implement in Popups using NavigationService and calling GoBack when the job completed.

@dansiegel dansiegel added Core Commercial Plus 🚀 Issue or Pull Request opened by a Commercial Plus license holder labels Jul 4, 2024
@dansiegel dansiegel added this to the vNext milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Commercial Plus 🚀 Issue or Pull Request opened by a Commercial Plus license holder Core enhancement
Projects
None yet
Development

No branches or pull requests

2 participants