Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title/options/connect screen uses different version from selected version #312

Open
kf106 opened this issue Jul 6, 2022 · 3 comments
Open
Labels
bug Something isn't working

Comments

@kf106
Copy link
Contributor

kf106 commented Jul 6, 2022

I conducted a test using flying squid with version 1.15.2 and prismarine-web-client with 1.15.2 so that I can connect to the flying-squid server with pwc.

I then deleted all the node_modules/prismarine-viewer/textures/ files and folders except for 1.15.2 folder and 1.15.2.png. The title screen buttons and the options and connect screen background image and buttons no longer have any image assets.

With a bit of trial and error I found that putting the 1.17.1 folder back returned the screens to normal.

Shouldn't the pwc initial screens use assets from the correction version folders rather than some other random version?

@KalmeMarq
Copy link
Contributor

the version is only selected when u want to play a server so... the only solution I can see is to use separated textures from the "pviewer/textures/*"

@kf106
Copy link
Contributor Author

kf106 commented Jul 6, 2022

There are a number of version inconsistencies in pwc. For example, I've just noticed that there's a request for something from 1.16.4 even though both fs and pwc are supposed to be on 1.15.2 when I look at the developer tools:

http://myserver:8080/textures/1.16.4/entity/cape_invisible.png

Similarly, in index.js there's a hardcoded reference to 1.16.4:

const m = new Entity('1.16.4', 'squid').mesh

const m = new Entity('1.16.4', 'squid').mesh

@kf106
Copy link
Contributor Author

kf106 commented Jul 6, 2022

the version is only selected when u want to play a server so... the only solution I can see is to use separated textures from the "pviewer/textures/*"

In that case, in my opinion, the few textures that are used should be in the assets folder, not grabbed from some random textures version folder. Or rather, several...

@rom1504 rom1504 added the bug Something isn't working label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants