Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth failures talk too much #35

Open
kaievns opened this issue Jun 29, 2016 · 0 comments
Open

auth failures talk too much #35

kaievns opened this issue Jun 29, 2016 · 0 comments

Comments

@kaievns
Copy link

kaievns commented Jun 29, 2016

when the signIn fails due to a wrong username or wrong password, the response error actually says either wrong username or wrong password.

this is a security vulnerability. firstly it tells the attacker that they've got the username right. and secondly it allows the attacker to check your system against existing email databases and know who's actually registered in the system.

the failure message should just say 'wrong username or password'. don't even mention 'email'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant