Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi @PriyaGhosal, I've identified the issue with the "X" icon not being visible in Dark Mode and would like to work on fixing it. #323

Closed
PragyaTripathi990 opened this issue Oct 7, 2024 · 2 comments

Comments

@PragyaTripathi990
Copy link
Contributor

Issue Title: "X" (Close) icon not visible in Dark Mode due to insufficient contrast.

Description: In Dark Mode, the "X" (Close) icon is not visible due to insufficient contrast between the icon and the background. This affects the user experience as it becomes difficult to identify and click the close button. The issue does not occur in Light Mode.

Expected Behavior: The "X" (Close) icon should have enough contrast to be visible in Dark Mode.
Actual Behavior: The icon blends with the background, making it hard to distinguish.
Steps to Reproduce:
Switch to Dark Mode.
Observe the "X" (Close) icon.
Screenshots:

Light Mode: Screenshot 2024-10-08 at 1 45 29 AM
Dark Mode: Screenshot 2024-10-08 at 1 40 15 AM
Proposed Solution: Increase the contrast of the "X" (Close) icon in Dark Mode, either by adjusting the color or adding a subtle outline around the icon.

Copy link

github-actions bot commented Oct 7, 2024

Thanks for creating the issue in SkillWise!
Before you start working on your PR, please make sure to:

  • ⭐ Star the repository if you haven't already.
  • Pull the latest changes to avoid any merge conflicts.
  • Attach before & after screenshots in your PR for clarity.
  • Include the issue number in your PR description for better tracking.
    Don't forget to follow @PriyaGhosal – Project Maintainer – & @anuragverma108 – Project Collaborator – for more updates!

We're excited to see your contribution as part of Hacktoberfest 2024! 🎉
Happy open-source contributing!

Copy link

github-actions bot commented Oct 7, 2024

Thank you for creating this issue! 🎉 Your issue will soon be reviewed by Project Maintainers. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants