Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing contributions matcher: Partial and incorrect payments are closing existing contributions #400

Open
thomasrenner opened this issue Sep 13, 2023 · 1 comment

Comments

@thomasrenner
Copy link

Problem: A payment with an amount greater than zero, that is registered by civiBanking, automatically closes an existing contribution, no matter if the payment amount matches the contribution amount or not. The status of the contribution is automatically set to "completed".
This is especially problematic if the payment is not a donation, but corresponds to e.g. an event fee or a membership fee.
We have attached 2 patches, that have basically fixed the Problem for us and that we would kindly ask for to be reviewed.
These patches were created during CiviSprint Leipzig 2023

Similar issue from 2020: #298

civibanking_partial_payment_defaultOptionMatcher.patch
civibanking_partial_payment_ExistingContributionMatcher.patch

@eptbertram
Copy link

Hej @thomasrenner , how to test those patches? Since I'm a noob I'll need some copy&paste-advice ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants