Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: lookup_contact_by_name with quickfind (API) mode, or no mode set fails: Contact getquick is removed as of CiviCRM 5.66 #424

Open
RositzaDikova opened this issue Jul 16, 2024 · 2 comments
Labels
bug incompatibility something that stopped working with a certain CiviCRM core version

Comments

@RositzaDikova
Copy link
Contributor

RositzaDikova commented Jul 16, 2024

Problem: The civi banking "Default Options" plug-in does not provide any suggestions (fails), when for lookup_contact_by_name no mode is set, or quickfind (API) mode is set.

Fix: Make sure you include specifically "mode":"sql" in your "Default Options" configuration, or plugins using lookup_contact_by_name
"lookup_contact_by_name": {
"mode": "sql",

BankingLookup.php (api/v3):

 // run the actual search
  if (empty($params['mode']) || $params['mode']=='getquick') {
    $contacts_found = _civicrm_api3_banking_lookup_contactbyname_api($name_mutations, $params);
  } elseif ($params['mode']=='sql') {
    $contacts_found = _civicrm_api3_banking_lookup_contactbyname_sql($name_mutations, $params);
  } else { // OFF / invalid
    $contacts_found = array();
  }

Switch menubar search to use APIv4 & delete deprecated v3 'getquick' action #26676

In doubt the BankingLookup.php will get updated to reflect this, but the issue might help users, if they fall in this scenario/situation.

@glanzel
Copy link

glanzel commented Oct 10, 2024

There are two Examples (Standardoptionen.civbanking and Zuwendung erstellen.civbanking) in the configuration_database without an "mode" set for "lookup_contact_by_name"
Maybe this should get fixed so people dont use these and think it should work.

@bjendres bjendres added the bug label Oct 18, 2024
@bjendres bjendres added this to the CiviBanking 1.2 milestone Oct 18, 2024
@bjendres
Copy link
Member

bjendres commented Oct 18, 2024

Thanks for the comprehensive analysis @RositzaDikova and @glanzel.

I think we should add a warning to people still using the getquick mode on CiviCRM >= 5.66.

Additionally, we could investigate if APIv4's Contact.autocomplete action could be a replacement.

@bjendres bjendres added the incompatibility something that stopped working with a certain CiviCRM core version label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug incompatibility something that stopped working with a certain CiviCRM core version
Projects
None yet
Development

No branches or pull requests

3 participants