Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleaning spree #34

Open
6 tasks
QGarchery opened this issue Sep 3, 2022 · 0 comments
Open
6 tasks

Code cleaning spree #34

QGarchery opened this issue Sep 3, 2022 · 0 comments

Comments

@QGarchery
Copy link
Contributor

QGarchery commented Sep 3, 2022

Steps to improve code readability / code style:

  • walk through the code and add comments / improve naming
  • use a general class for the state (call it Blockchain), and store all global variables in it
  • use a function to check if a transaction is a reward transaction
  • use str instead of repr everywhere, define one way to get the address from a pub key
  • logging vs printing in tests
  • anchor_prev should be anchor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant