Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Modules plugin (experimental) #1221

Open
thescientist13 opened this issue Apr 26, 2024 · 2 comments
Open

HTML Modules plugin (experimental) #1221

thescientist13 opened this issue Apr 26, 2024 · 2 comments
Labels
documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins SSR
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 26, 2024

Summary

Coming out of the work done in #923, it would be nice to have some form of support for HTML Modules (at least our interpretation of it). Ex:

<!-- hero.html -->
<div class="hero">
  <h2>Welcome to my website</h2>
  
  <a href="#">
    <button>Get Started</button>
  </a>
  <a href="#">
    <button>Learn More &#8594</button>
  </a>

</div>
import template from "./hero.html" with { type: "html" };

export default class HeroBanner extends HTMLElement {
  connectedCallback() {
    if (!this.shadowRoot) {
      this.attachShadow({ mode: 'open' });
      this.shadowRoot.appendChild(template.content.cloneNode(true));
    }
  }
}

customElements.define('app-hero', HeroBanner);

As a super duper bonus would be great to also get some sort of DOM Parts / templating API in there too (which might require WCC support)

<!-- card.html -->
<div class="card">
  <h2>{{heading}}</h2>
  <img src="{{imageUrl}}" alt="{{heading}}"/>
</div>
import template from "./card.html" with { type: "html" };

export default class Card extends HTMLElement {
  connectedCallback() {
    if (!this.shadowRoot) {
      template.replace('heading', this.getAttribute('heading'));
      template.replace('imageUrl', this.getAttribute('imageUrl'));

      this.attachShadow({ mode: 'open' });
      this.shadowRoot.appendChild(template.content.cloneNode(true));
    }
  }
}

customElements.define('app-card', Card);

And use it like this

<app-card
  heading="My Item"
  imageUrl="/path/to/image.png"
></app-card>

Details

Would definitely to call this out as experimental and very much an interpretation of the specification, and should probably start a discussion to track those future facing implementations for when they land / co-alece at the standards level.

Would be nice to see if this could be used in conjunction with #955 to achieve something like this?

import fragment from './html?type=html';

export default class PageLayout extends HTMLElement {
  async connectedCallback() {
    this.innerHTML = fragment.innerHTML;
  }
}

Might also want to revisit our html-includes plugin and deprecate the the Custom Element flavor since I think this was all conceived before SSR and WCC? 🤔

@thescientist13 thescientist13 added documentation Greenwood specific docs Plugins Greenwood Plugins SSR feature New feature or request v0.30.0 labels Apr 26, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Apr 26, 2024
@thescientist13 thescientist13 changed the title (experimental) HTML Modules plugin HTML Modules plugin (experimental) Apr 26, 2024
@thescientist13 thescientist13 changed the title HTML Modules plugin (experimental) HTML Modules plugin (experimental) Apr 26, 2024
@thescientist13 thescientist13 mentioned this issue Apr 26, 2024
39 tasks
@thescientist13 thescientist13 moved this from 🔖 Ready to ➡ DEFERRED in [Greenwood] Phase 9 - Standards and Conventions Jul 20, 2024
@MrHBS
Copy link

MrHBS commented Aug 15, 2024

Very nice proposal from Rob if you need inspiration :D https://gist.github.com/EisenbergEffect/8ec5eaf93283fb5651196e0fdf304555

@thescientist13
Copy link
Member Author

thescientist13 commented Aug 19, 2024

Hey @MrHBS , thanks for sharing!

I think I've seen that one before and if I understand it correctly, I think that one in particular focuses more the SFC (Single File Component) side of things? I think that could definitely be interesting to consider, though I haven't used SFC based tools myself much, but I like the idea in spirit, at least when looking at code snippets of projects like Svelte. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins SSR
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants