Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microservices that use a webhook should replace PROVIDER_BASE_URL with WEBHOOK_BASE_URL #218

Closed
4 tasks done
mattheworris opened this issue Jun 14, 2024 · 1 comment · Fixed by #350
Closed
4 tasks done

Comments

@mattheworris
Copy link
Contributor

mattheworris commented Jun 14, 2024

Description

The gateway microservices that use webhooks previously used the environment variable PROVIDER_BASE_URL as the webhook target server. The social-app-template has adopted a new nomenclature using WEBHOOK_BASE_URL. All micro services should be in sync with the social-app-template and use the new nomenclature.

Acceptance Criteria

All microservices that use webhooks use WEBHOOK_BASE_URL to provision their webhook.

Follow up to remove entirely: #339

@JoeCap08055
Copy link
Contributor

Actually, WEBHOOK_BASE_URL in SAT is meant to be used with services that allow for webhook registration a la content-watcher. Any Gateway services currently using a statically-configured webhook should instead adopt an ability to dynamically register webhooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment