Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n support #69

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

I18n support #69

wants to merge 7 commits into from

Conversation

lutzhelm
Copy link
Contributor

These are the changes from @regisrob's PR #59 with merge conflicts resolved and some additional changes:

  • use the best practice pattern for interpolation, e.g. to support RTL languages
  • use a plugin specific prefix to avoid translation key collisions
  • added a German translation

@lutzhelm lutzhelm requested a review from cbeer November 25, 2024 13:12
@lutzhelm
Copy link
Contributor Author

lutzhelm commented Nov 25, 2024

@cbeer You had a look at #59 before (although it's been three years), would you mind reviewing this? If so, I could give this to Gerd instead...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants