Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no component target for a plugin targeting paintable resources of type 'Text' #4085

Closed
barmintor opened this issue Jan 28, 2025 · 0 comments · Fixed by #4086
Closed

There is no component target for a plugin targeting paintable resources of type 'Text' #4085

barmintor opened this issue Jan 28, 2025 · 0 comments · Fixed by #4086
Labels
Plugins 🔌

Comments

@barmintor
Copy link
Contributor

TypeSpecificViewer (in PrimaryWindow.js) falls through to WindowViewer (ie, OSD) when all resources that are not audio or video. We should ship a TextViewer component that acts just like WindowViewer, but provides a plugin target for better display of e.g. PDFs.

This would also require some minor additions to the canvas selectors to support filtering resources of type 'Text'.
barmintor added a commit to cul/mirador that referenced this issue Jan 29, 2025
@barmintor
Core mirador behaviors to provide a plugin target for text resources
7c63af6 
- refactor type-based filters into a module
- MiradorCanvas.imagesResources does not assume any service is an image service
- stub TextViewer shows empty div, source elements for text resources, and canvas navigation
- fixes ProjectMirador#4085
@barmintor barmintor mentioned this issue Jan 29, 2025
Merged
barmintor added a commit to cul/mirador that referenced this issue Jan 29, 2025
@barmintor
Core mirador behaviors to provide a plugin target for text resources
093d303 
- refactor type-based filters into a module
- MiradorCanvas.imagesResources does not assume any service is an image service
- stub TextViewer shows empty div, source elements for text resources, and canvas navigation
- fixes ProjectMirador#4085
barmintor added a commit to cul/mirador that referenced this issue Feb 2, 2025
@barmintor
Core mirador behaviors to provide a plugin target for text resources
c43330e 
- refactor type-based filters into a module
- MiradorCanvas.imagesResources does not assume any service is an image service
- stub TextViewer shows empty div, source elements for text resources, and canvas navigation
- fixes ProjectMirador#4085
barmintor added a commit to cul/mirador that referenced this issue Feb 3, 2025
@barmintor
Core mirador behaviors to provide a plugin target for text resources
8840c83 
- refactor type-based filters into a module
- MiradorCanvas.imagesResources does not assume any service is an image service
- stub TextViewer shows empty div, source elements for text resources, and canvas navigation
- fixes ProjectMirador#4085
barmintor added a commit to cul/mirador that referenced this issue Feb 9, 2025
@barmintor
Core mirador behaviors to provide a plugin target for text resources
dd56281 
- refactor type-based filters into a module
- MiradorCanvas.imagesResources does not assume any service is an image service
- stub TextViewer shows empty div, source elements for text resources, and canvas navigation
- fixes ProjectMirador#4085
barmintor added a commit to cul/mirador that referenced this issue Feb 11, 2025
@barmintor
Core mirador behaviors to provide a plugin target for text resources
5120821 
- stub TextViewer shows empty div, source elements for text resources, and canvas navigation
- fixes ProjectMirador#4085
barmintor added a commit to cul/mirador that referenced this issue Feb 11, 2025
@barmintor
Core mirador behaviors to provide a plugin target for text resources
cf770ed 
- stub TextViewer shows empty div, source elements for text resources, and canvas navigation
- fixes ProjectMirador#4085
barmintor added a commit to cul/mirador that referenced this issue Feb 12, 2025
@barmintor
COLUMBIA: Core mirador behaviors to provide a plugin target for text …
2599fa5 
…resources

- refactor type-based filters into a module
- MiradorCanvas.imagesResources does not assume any service is an image service
- stub TextViewer shows empty div, source elements for text resources, and canvas navigation
- fixes ProjectMirador#4085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Plugins 🔌
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Core mirador behaviors to provide a plugin target for text resources cul/mirador
1 participant
@barmintor