Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncating of resource gallery cards splits strings mid-word #168

Closed
jukent opened this issue Sep 23, 2021 · 1 comment
Closed

Truncating of resource gallery cards splits strings mid-word #168

jukent opened this issue Sep 23, 2021 · 1 comment
Labels
infrastructure Infrastructure related issue

Comments

@jukent
Copy link
Contributor

jukent commented Sep 23, 2021

The current string splitting method in the _extensions/yaml_gallery_generator.py cuts strings off at a certain length (with a recent fix in #147 to not break any html). This is done when the description for a resource is longer than a certain length, and a "...more" modal is added.

Ideally this string-splitting would be a little more sophisticated and not split strings mid-word, but either before or after the closest word to our desired length.

@jukent jukent added the infrastructure Infrastructure related issue label Sep 23, 2021
@kmpaul
Copy link
Collaborator

kmpaul commented Oct 7, 2021

This is done with the merging of #147.

@kmpaul kmpaul closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issue
Projects
None yet
Development

No branches or pull requests

2 participants