Rescale unevenly sized panos

[michaelduan8]

As @shokiami mentioned here (#22 ), we see that some of the scraped panos are smaller and result in black space on the bottom and right sides. Two things we noticed is that the SV image coordinates don't line up correctly with the poorly scaled images (so some label crops end up just being completely black) and our generated null crops sometimes are chosen such that the resulting null crop is largely/completely black.

[misaugstad]

Right. If you look at the DownloadRunner code (I think) you'll notice conditionals trying to figure out the correct size of the panorama. Most panos are the same size, but there are some that are smaller. And it looks like the downloader didn't realize that correctly sometimes.

[jonfroehlich]

Would be good to loop back and solve this problem at its source then (in the DownloadRunner) code...

[misaugstad]

Coming back now that I have a bit more time. There are two places where this needs to be fixed upstream. The first is in the Project Sidewalk code. I mention in this issue that it seems that the image width/height were hardcoded from the beginning, though I found out that we can actually get that information from the JavaScript API. So we should start to fill in those values in the database correctly from now on.

The 2nd thing to do is to make sure that whatever API endpoint that DownloadRunner uses to get Project Sidewalk data actually includes the image_width and image_height parameters.

And finally, the DownloadRunner can then be modified to just use those parameters instead of trying (and occasionally failing) to guess which size it's going for.

That still leaves the question of what to do about past data. We might want to write a script to go in and clean up the old panoramas (cropping out the black areas) on the SFTP server. But that should be the last step.

[michaelduan8]

Wanted to reopen this since this is still a pretty large issue given where it propagates from and the current fix is only a temporary one to meant to meet an oncoming deadline.