Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CropRunner dropping rows with duplicate 'gsv_panorama_id' #31

Open
PabloMoret opened this issue Aug 9, 2023 · 1 comment
Open

CropRunner dropping rows with duplicate 'gsv_panorama_id' #31

PabloMoret opened this issue Aug 9, 2023 · 1 comment
Labels

Comments

@PabloMoret
Copy link
Contributor

There's a fault in CropRunner.py, specifically a non-intended behaviour while reading the metadata csv file.

Line 72

df_meta = df_meta.drop_duplicates(subset=['gsv_panorama_id']).to_dict('records')

This code logic is actually dropping labels with the same gsv_panorama_id. Needs to be changed to:

df_meta = df_meta.drop_duplicates(subset=['label_id']).to_dict('records')

Though is an easy-to-fix issue I don't have time to do it now. Just wanted you to be advised.

@misaugstad
Copy link
Member

Thank you for pointing that one out!! It was missed because we want to default to using an API request over using a CSV, but we definitely need to fix this backup option!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: next up
Development

No branches or pull requests

2 participants