Redis - Metrics collection should not write anything (#165)

Signed-off-by: Jakub Pastuszek <[email protected]> Co-authored-by: Jakub Pastuszek <[email protected]>
PromPHP · Dec 2, 2024 · d6233cc · d6233cc
1 parent 6d7328e
commit d6233cc
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/Prometheus/Storage/Redis.php b/src/Prometheus/Storage/Redis.php
@@ -536,7 +536,11 @@ private function collectSummaries(): array
                 }
 
                 if (count($samples) === 0) {
-                    $this->redis->del($valueKey);
+                    try {
+                        $this->redis->del($valueKey);
+                    } catch (\RedisException $e) {
+                        // ignore if we can't delete the key
+                    }
                     continue;
                 }
 
@@ -571,7 +575,11 @@ private function collectSummaries(): array
             if (count($data['samples']) > 0) {
                 $summaries[] = $data;
             } else {
-                $this->redis->del($metaKey);
+                try {
+                    $this->redis->del($metaKey);
+                } catch (\RedisException $e) {
+                    // ignore if we can't delete the key
+                }
             }
         }
         return $summaries;