Skip to content
This repository has been archived by the owner on Jul 25, 2019. It is now read-only.

[Suggestion] Allow rocky_plains snowfall with SereneSeasons #37

Open
nick-johnson opened this issue Jan 10, 2019 · 3 comments
Open

[Suggestion] Allow rocky_plains snowfall with SereneSeasons #37

nick-johnson opened this issue Jan 10, 2019 · 3 comments

Comments

@nick-johnson
Copy link

https://github.com/Prospector/Traverse/blob/776d4a90743370e9956ab899dca8c35c4c78fd1a/src/main/java/prospector/traverse/world/biomes/BiomeRockyPlains.java#L29

https://github.com/Glitchfiend/SereneSeasons/blob/f67ed87d7cd00287d636769e5a1e7593ebc2ac76/src/main/java/sereneseasons/season/SeasonASMHelper.java#L185

The traverse:rocky_plains biome temperature is warm enough (0.9F > 0.8F) that it doesn't receive snowfall in winter through Serene Seasons. Is this by default? A lot of similar biomes (e.g. woodlands, plains, etc.) have a <=0.8F temperature.

@Prospector
Copy link
Owner

Prospector commented Jan 13, 2019

Hmm... I suppose I can tweak it to 0.8F, though it is meant to be a bit warmer than the plains biome, which is 0.8F.

@nick-johnson
Copy link
Author

Definitely makes sense to have it the biome slightly warmer, just seemed strange without snowfall with it as cool biome. It's a very slim temperature range between 0.8F and the 0.95F jungle biomes. Maybe @Forstride will consider bumping the cut-off for snow to 0.85 and meet in the middle?

@Forstride
Copy link

I mean if it's supposed to be warmer than the plains, it probably shouldn't snow then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants