Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Towncraft Two] Day/Night cycle out of sync for Journey Map and Mine Colonies when in Middle Earth #60

Open
mummabia opened this issue Jun 15, 2021 · 5 comments

Comments

@mummabia
Copy link

Hi - Journey map and Mine Colonies Day/Night Cycle is out of sync .

Journey mini map shows 10 and sunset and mine colonies npcs go to 'sleep'. However, a Minecraft clock shows midday and it is daytime in the world (The Shire). Shortly later the mini map shows night.

The shire date text (assuming this is to notify of a new day in the world) appears across your screen at 00:01 and it shows daytime on mini map but it is actually just before sunset in the world (still sunny) and NPCs are moving about.

When it becomes night time in the world, it's 3 Daytime on Journey map and the NPCs are moving about.

Thanks

@ProsperCraft ProsperCraft changed the title [Towncraft Two] Day/Night cycle out of sync for Journey Map and Mine Colonies [Towncraft Two] Day/Night cycle out of sync for Journey Map and Mine Colonies when in Middle Earth Jun 15, 2021
@ProsperCraft
Copy link
Owner

Crossposted to LOTR discord, which is where they track bugs.

@ProsperCraft
Copy link
Owner

Lars Ludwich (floppa cat): The relevant mods will need to call world#getCelestialAngle or similar methods, instead of handling the world time directly (vanilla does the first for sun position, sky light, cat sleeping ai etc)

@Raycoms
Copy link

Raycoms commented Jun 16, 2021

Ahh, that doesn't work for us at least, because that doesn't work in custom dimensions.

@TheChildWalrus
Copy link

Hi, I'm the lotr mod developer - why doesn't it work in custom dimensions?
The methods I'm talking about are (in MCP names): DimensionType#getCelestrialAngleByTime, IDayTimeReader#func_242415_f - either should return the same.

@Raycoms
Copy link

Raycoms commented Jun 16, 2021

Because there is no celestrial angle in the nether most likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants