-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sciex 7500 RT Ranges Converted Incorrectly #2327
Comments
Is this a problem that only affects the 7500 or are we calculating it wrong for all Sciex MRM files? |
Good question, but unfortunately I don't know - my group only has the 7500 and haven't checked other Sciex instruments. |
Hey @chambm, We reached out to Sciex to see if they could provide some files from other Sciex instruments from scheduled MRM runs. Hopefully, they'll add some to the google drive folder (https://drive.google.com/drive/folders/1R9C0dZqDGAlGYLvj-h9Jh_HWs2SQuSTQ). If you have time to look into the issue sometime soon, I'd greatly appreciate it. |
Hi @chambm, we've been talking to Sciex about this issue and we strongly believe the problem is that their new software, SCIEX OS, writes retention time windows into both the wiff and wiff2 files as +/- ranges, whereas the old software, Analyst, writes retention time windows as a complete range. So all instruments running SCIEX OS will likely have this same issue (read: newer models). Sciex is expanding this new software to more instrument models, so I expect this problem will only become more prevalent. Sciex has agreed to fix this internally, but we still need a solution in the interim. Is it possible to create an option to double the RT window size from Sciex files? That would give us a fix now and allow us to process data. A flag that can be turned on and off would be best, so we can turn it off when Sciex comes through with their fix. I have asked Sciex to provide an example data file collected from their older Analyst software and will comment back here when data is added. Until then our data created from SCIEX OS can be found here: https://drive.google.com/drive/folders/1R9C0dZqDGAlGYLvj-h9Jh_HWs2SQuSTQ. This work is greatly appreciated! |
Based on a conversation with David Cox from Sciex I believe @brendanx67 has been working with them on this issue. |
@brendanx67 and @chambm Any updates on this issue? If there's any way I can help speed up the process let me know, I'd be happy to help |
Hey @chambm and @brendanx67 , |
We're still working on it. We'd like to have an automatic fix to adjust the RT window only for files that were acquired with the affected SCIEX OS versions. |
@PMSeitzer @cmsand See if the build here fixes it for you (after it finishes building): You only provided an unscheduled MRM file as far as I can tell, so I couldn't test on your file. |
@david-cox-sciex I just noticed you did some stuff in their Google Drive share yesterday. Looks like we were working on the same thing independently. Did you ever get a different version for the bug fix? It's a potential problem if the bug was fixed in 3.0 or 2.9 or something but the automatic detection code thinks not. @PMSeitzer Oh, I forgot to mention that I accidentally committed some test code back in November. Since then, RTWindows for WIFF files have been assumed to be half-width instead of full-width. So if you had msconvert newer than that it should have already been fixed for you (at the cost of breaking Analyst-collected files!) |
Thank you @chambm for the work, and apologies about the unscheduled data files! Yes, recently @david-cox-sciex has been helping with this issue. Some recent updates:
See example chromatogram below. This is data from sample 40 of the example 3.1 data. Transition 1-Methyl-Histidine 3 which should have an RT window of +/- 80 seconds, but only shows a window of +/- 30 seconds. It was converted with the following command: |
It's worth noting that the first 20 samples in the 3.1 example .wiff data I shared were collected with 1 min RT windows for positive transitions and 1.66 min windows for negative transitions to determine if the mzML files would maintain those same window lengths. And, in fact, they do. All 40 of the mzML data files have the same RT windows (within rounding error) after conversion despite samples 21-40 being collected with wider RT windows. |
Ah, several things here.
|
@chambm, thanks for the response
|
I forgot to mention. In the OS3.0 example data I shared, the sample named |
I also see the same RTWindows widths in all the 3.1 samples I checked (several sample numbers < 20 and > 20). Are you sure this isn't an instrument method or acquisition issue? |
Here is an example from Sample 40 of the OS3.1 data from the google drive folder. The transition 1-Methyl-Histidine 3 is shown from the .wiff file in the Sciex Explorer software (above), and after conversion to mzML (below). I believe the acquisition is fine because I am able to see the full RT window from the .wiff data file. Once it's converted to mzML the RT window truncates. @david-cox-sciex was able to reproduce this issue on his end with the same data. Dave, any initial thoughts on what's going on? |
Try the msconvert build from this PR's installer you can download here: https://teamcity.labkey.org/viewLog.html?buildId=2276603&buildTypeId=bt83&tab=artifacts&guest=1 It should fix the partial MRM array issue if I'm not mistaken. |
@chambm It seems that build of proteowizard required .NET Framework 4.8 to run. The 7500 computer was installed with 3.5 and updating caused connection issues with SciexOS3.1, so we had to revert before testing conversion. We're getting in touch with Sciex to see if there's a way we can update our .NET framework. Is there a way to get an msconvert build compatible with an older version of .NET? Re: your question about the MRM Detection Window. We can't find any option to control that parameter in OS3.1. Is that something set in the Sciex software or by Proteowizard? |
Yes we recently upgraded the .NET requirement. But before that, for several years it required .NET 4.7.2 instead, so you can't merely have 3.5. In any case you can install ProteoWizard on another computer and convert files there. I think that's how most users run it since they have often access to raw data but not the instrument computers. I don't know anything about the MRM detection window, but it was something another user mentioned having this issue with partial MRM arrays. Can you SEE the value, even if you can't change it? |
Pulling in @PMSeitzer for help to test the new Proteowizard build on another computer since we all run Macs, and Ive never done that install outside Windows. @chambm, not, we can't even see the value. The only access to RT windows that we have (or that we know of) is in the MRM method table which are the values we've been referring to. Will ping Sciex to see if we're missing something. |
Hi @chambm and @cmsand , I built the custom proteowizard on a different windows 10 VM. Proteowizard was able to install successfully, and convert the files properly with no error, but unfortunately, the transitions still have rt width of 1 min exactly: Here is the command I used:
Here is an example
|
@chambm It might also be worth mentioning that when I tried the same conversion command on a
|
I think that is correct according to this:
Can you check one of the negative polarity chromatograms and samples > 20? |
Here is a negative polarity chromatogram: Every color series is a different sample, and the range of data is abruptly truncated at From
the RT window is always the same for each sample - 1 min for positive transitions, and 1.66 for negative. This is true for all samples, regardless of injection number. I have added the output as a folder |
Clearly something in the API thinks that all those samples are 1 min for positive and 1.6 minutes for negative transitions. It doesn't seem to be a SciexOS <3.1 bug. I've pushed a new fix which seems to workaround that issue by just telling it to get the XIC from the entire time range instead of what the RTWindow says. It's currently in msconvert.exe only: |
@david-cox-sciex Is Sciex tracking this as a bug? Because the data was clearly recorded for twice as long as the RTWindow suggests for the 20230202_Post-Pump-Repair_Testing.wiff file for the second half of the samples (21-40). |
@chambm Tested the PR for msconvert 3.0.23048.489631b, Very happy to report that with this new build and CLI option Here are screenshots of the Note RT windows of |
Scheduled data collected on the Sciex 7500 is formatted using a one-sided RT range tolerance value.
msconvert is currently treating this one-sided RT range tolerance value as though it were a complete RT range, and defines the RT range based on centering the RT transition value on the one-sided RT range tolerance.
For example, a transition has an RT of
16.9 minutes
, with an RT range tolerance of60 seconds
. The correct RT range for this transition should be15.9 min - 17.9 min
(60 seconds on either side).msconvert is currently computing the RT range as
16.4 min - 17.4 min
(30 seconds on either side, centered at correct transition value).Here is a real example of the RT range being incorrectly parsed from an
mzML
file generated by msconvert:This snippet comes from the file
X0198-eicosanoids-in-macrophages-X0198-12_APP_medium_1mL-1.mzML
which is available in this google drive:
https://drive.google.com/drive/folders/1R9C0dZqDGAlGYLvj-h9Jh_HWs2SQuSTQ
Which @chambm has access to.
Apparently, this is a known problem that the folks at Sciex warn their customers about, since it frequently causes a lot of confusion.
I used the proteowizard version released after #2272 (see PR #2273).
Thank you in advance - the latest proteowizard has been working very well for sciex 7500 data, with the exception of the RT range issue.
The text was updated successfully, but these errors were encountered: