You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
I was looking at my own feature request, see below, and trying to implement this in Skyline myself. [0]
This would simply need .Contains instead of .StartsWith in ViewLibraryPepInfoList.cs#307. However .NET Framework 4.7.2 does not have the case-insensitive Contains yet. [1] Their suggested workaround [1] is to write a string extension method. If I wanted this PR to be eventually merged, where would be the right place to put such a method?
This would simply need .Contains instead of .StartsWith in ViewLibraryPepInfoList.cs#307.
As I see now, this is actually not the case, instead we need a new ContainsSearchByProperty to complement PrefixSearchByProperty. The workaround to add String.Contains is still necessary.
The question is whether a Contains search can be fast enough.
meowcat
pushed a commit
to meowcat/pwiz
that referenced
this issue
Oct 13, 2023
Hi,
I was looking at my own feature request, see below, and trying to implement this in Skyline myself. [0]
This would simply need
.Contains
instead of.StartsWith
in ViewLibraryPepInfoList.cs#307. However .NET Framework 4.7.2 does not have the case-insensitiveContains
yet. [1] Their suggested workaround [1] is to write a string extension method. If I wanted this PR to be eventually merged, where would be the right place to put such a method?Would you be interested in merging this at all?
[0] https://skyline.ms/announcements/home/support/thread.view?rowId=62625
[1] https://learn.microsoft.com/en-us/dotnet/api/system.string.contains?view=netframework-4.7.2#system-string-contains(system-string-system-stringcomparison)
The text was updated successfully, but these errors were encountered: