Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectral Library Explorer filter, "StartsWith" vs "Contains" #2748

Closed
meowcat opened this issue Oct 13, 2023 · 2 comments
Closed

Spectral Library Explorer filter, "StartsWith" vs "Contains" #2748

meowcat opened this issue Oct 13, 2023 · 2 comments

Comments

@meowcat
Copy link

meowcat commented Oct 13, 2023

Hi,
I was looking at my own feature request, see below, and trying to implement this in Skyline myself. [0]

This would simply need .Contains instead of .StartsWith in ViewLibraryPepInfoList.cs#307. However .NET Framework 4.7.2 does not have the case-insensitive Contains yet. [1] Their suggested workaround [1] is to write a string extension method. If I wanted this PR to be eventually merged, where would be the right place to put such a method?

Would you be interested in merging this at all?

[0] https://skyline.ms/announcements/home/support/thread.view?rowId=62625
[1] https://learn.microsoft.com/en-us/dotnet/api/system.string.contains?view=netframework-4.7.2#system-string-contains(system-string-system-stringcomparison)

@meowcat
Copy link
Author

meowcat commented Oct 13, 2023

This would simply need .Contains instead of .StartsWith in ViewLibraryPepInfoList.cs#307.

As I see now, this is actually not the case, instead we need a new ContainsSearchByProperty to complement PrefixSearchByProperty. The workaround to add String.Contains is still necessary.

The question is whether a Contains search can be fast enough.

@meowcat
Copy link
Author

meowcat commented Nov 3, 2023

Thanks for support & merging!

@meowcat meowcat closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant