Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skyline: Clean-up "StaticMod.PrecisionRequired" changes #2765

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

brendanx67
Copy link
Contributor

  • These changes ended up not getting used and just add confusion to the code
  • Revert UniModCompiler/InputFiles/unimod.xml to what was actually used to generate UniModData.cs
  • Add a few changes to UniModTemplate.cs to make it match UniModData.cs

- These changes ended up not getting used and just add confusion to the code
- Revert UniModCompiler/InputFiles/unimod.xml to what was actually used to generate UniModData.cs
- Add a few changes to UniModTemplate.cs to make it match UniModData.cs
@brendanx67
Copy link
Contributor Author

Unsure why I ended up with so much whitespace changed in Program.cs. Not how it looks in TortoiseMerge on my machine. Change is clearer with Hide Whitespace checked in the GitHub diff view.

@brendanx67
Copy link
Contributor Author

Nick, I decided to do a bit of clean-up of the "RequiredPrecision" code before applying my unimod.xml update in the hope that doing this will make the update easier to understand without all the changes to precision required for the modifications. Glad you final solution did not require this attribute. It does make a bit of a mess out of updates.

Copy link
Contributor

@nickshulman nickshulman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I fixed the line endings on Program.cs using a checkout which had the AutoCRLF git setting set to "false".
It looks like back in 2016 that file had some unix style line endings, so when you reverted to it, you got those line endings.

@brendanx67 brendanx67 merged commit fafbb32 into master Nov 1, 2023
@brendanx67 brendanx67 deleted the Skyline/work/20231031_unimod_rollback branch November 1, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants