Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Assume failure in "SpectraChromDataProvider.ChromIds" #2787

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

nickshulman
Copy link
Contributor

@nickshulman nickshulman commented Nov 27, 2023

Fix error extracting chromatograms from raw file when there are pressure traces but no MS1 spectra (reported by Bill)

@nickshulman nickshulman added the Cherry pick to release Merging PRs to master with this will create a new PR that CPs all commits to Skyline release branch label Nov 27, 2023
@nickshulman nickshulman marked this pull request as ready for review November 27, 2023 16:22
@nickshulman
Copy link
Contributor Author

/rebase

@github-actions github-actions bot force-pushed the Skyline/work/20231126_FixChromIdAssert branch from 8f9fa6e to 75e5d77 Compare November 27, 2023 23:22
@nickshulman nickshulman merged commit 1e2b5ba into master Nov 27, 2023
nickshulman added a commit that referenced this pull request Nov 28, 2023
Fix error extracting chromatograms from raw file when there are pressure traces but no MS1 spectra (reported by Bill)
nickshulman added a commit that referenced this pull request Nov 28, 2023
)

Fix error extracting chromatograms from raw file when there are pressure traces but no MS1 spectra (reported by Bill)
@nickshulman nickshulman deleted the Skyline/work/20231126_FixChromIdAssert branch March 28, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cherry pick to release Merging PRs to master with this will create a new PR that CPs all commits to Skyline release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant