Figure out why StackOverflowException on TeamCity is not a failure

[nickshulman]

Trying to track down why TeamCity does not notice that a StackOverflowException which causes TestRunner.exe to abruptly exit with exit code 2147943401 should be treated as a test failure.

[chambm]

I'm pretty sure this has to be either test runner or boost build. So it should be reproducible locally but I haven't tried yet. Did you?

…

On Wed, Dec 6, 2023, 6:35 PM nickshulman ***@***.***> wrote: Trying to track down why TeamCity does not notice that a StackOverflowException which causes TestRunner.exe to abruptly exit with exit code 2147943401 should be treated as a test failure. ------------------------------ You can view, comment on, or merge this pull request online at: #2805 Commit Summary - b1e7188 <b1e7188> Trying to track down why TeamCity does not notice that a StackOverflowException which causes TestRunner.exe to abruptly exit with exit code 2147943401 should be treated as a test failure. File Changes (2 files <https://github.com/ProteoWizard/pwiz/pull/2805/files>) - *A* pwiz_tools/Skyline/TestFunctional/StackOverflowExceptionTest.cs <https://github.com/ProteoWizard/pwiz/pull/2805/files#diff-f95f853603dc49f38c0ba7246e0391d0c23d676087d0572b9903ba9c8039405f> (31) - *M* pwiz_tools/Skyline/TestFunctional/TestFunctional.csproj <https://github.com/ProteoWizard/pwiz/pull/2805/files#diff-8c7438863e1d70209283a4ad3e07e26809010c6ac0e37e782c725095eca87db6> (1) Patch Links: - https://github.com/ProteoWizard/pwiz/pull/2805.patch - https://github.com/ProteoWizard/pwiz/pull/2805.diff — Reply to this email directly, view it on GitHub <#2805>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGHTYK3B4OXR4JSHGV4OB3YID6MXAVCNFSM6AAAAABAKFPZH2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDSNJXGM4DMMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[chambm]

It just hung indefinitely. When I run it from Boost.Build, your version of the stack overflow test hangs on my machine locally as well. When I try to attach and break to see what's happening, I get:

and it seems to exits with code 0. When I start it from the Visual Studio debugger, I get the stack overflow immediately and it exits non-zero.

I made my own version before you made this PR. It didn't go through DoTest, the [TestMethod] just called itself directly. Running that via Boost.Build did exit with stack overflow exception and non-zero exit code. But your version is closer to what the functional test actually did.

Perhaps the easiest way forward would be to set a TC failure condition on the string terminated due to StackOverflowException and also end the build immediately to avoid the hang.

[nickshulman]

Looks like TeamCity now correctly detects the stack overflow message in the build log.