BiblioSpec pepXML check base_name parent path #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chambm
commented
Dec 8, 2023
chambm
commented
- fixed BiblioSpec pepXML reader to check for spectrum files in the base_name's parent path (if present)
…ase_name's parent path (if present)
|
Ugh. Must fix it to parse Windows paths on Linux and Linux paths on Windows. |
Huh. I expect the C# Path class to do this in .NET. I guess you are saying the bsf::path does not support this automatically. |
|
Works for me. Waiting for tests to pass and then I will merge. |
brendanx67
deleted the
Skyline/Bugfix/blib-pepxml-check-parent-path-first
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.