Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open data source dialog refactor #3245

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Open data source dialog refactor #3245

merged 2 commits into from
Dec 11, 2024

Conversation

chambm
Copy link
Member

@chambm chambm commented Nov 27, 2024

No description provided.

@danjasuw danjasuw force-pushed the Skyline/work/20241108_OpenDataSourceDialog_refactor branch 2 times, most recently from b88b453 to b6a3023 Compare December 8, 2024 20:47
@danjasuw
Copy link
Contributor

danjasuw commented Dec 8, 2024

In BaseFileDialogNE
I was unsure how to rename the "Open" button name to "Action" without breaking the label in the other languages.
A similar problem for adding setting the button text in OpenFileDialogNE constructor to "Open".
Maybe someone who understands how to make these changes can make them.

@danjasuw
Copy link
Contributor

danjasuw commented Dec 8, 2024

I rebase on master and force push to ensure the file renames in the first commit work properly.

@danjasuw danjasuw force-pushed the Skyline/work/20241108_OpenDataSourceDialog_refactor branch from b6a3023 to 604c3a3 Compare December 10, 2024 18:58
@danjasuw
Copy link
Contributor

I found in the Skyline UI where to change the language so I could test that my code and resx changes were working as expected.

I made changes to the base form and manually updated the resx files for the other languages.
I manually copied the text labels from the base from resx files for the other languages to the derived class so that they would be already copied.

@danjasuw
Skyline: Refactor form OpenDataSourceDialog: Rename to base: DOES NOT…
9b73b24 
… BUILD

This commit DOES NOT BUILD.
Separate GIT commit so rename of files works.
Rename Form OpenDataSourceDialog to BaseFileDialogNE.
Following commits will add new subclasses OpenFileDialogNE and OpenDataSourceDialog
@danjasuw danjasuw force-pushed the Skyline/work/20241108_OpenDataSourceDialog_refactor branch 2 times, most recently from f683cfa to 25c56a4 Compare December 11, 2024 15:20
@chambm chambm marked this pull request as ready for review December 11, 2024 15:25
@danjasuw danjasuw force-pushed the Skyline/work/20241108_OpenDataSourceDialog_refactor branch from 25c56a4 to cf17207 Compare December 11, 2024 15:54
@danjasuw
Skyline: Refactor OpenDataSourceDialog: Finish updates
a48e8ad 
As part of previous commit and this commit:
Rename OpenDataSourceDialog to BaseFileDialogNE
Add new empty classes OpenFileDialogNE and OpenDataSourceDialog
New inheritance path: BaseFileDialogNE > OpenFileDialogNE > OpenDataSourceDialog
Move Open() method to class OpenFileDialogNE
@danjasuw danjasuw force-pushed the Skyline/work/20241108_OpenDataSourceDialog_refactor branch from cf17207 to a48e8ad Compare December 11, 2024 16:09
@chambm chambm merged commit 07bee8f into master Dec 11, 2024
11 checks passed
@chambm chambm deleted the Skyline/work/20241108_OpenDataSourceDialog_refactor branch December 11, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjasuw danjasuw danjasuw left review comments

Assignees

@danjasuw danjasuw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chambm @danjasuw