Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opposite ticks on dotp axis #3246

Conversation

eduardo-proteinms
Copy link
Collaborator

No description provided.

Copy link
Contributor

@brendanx67 brendanx67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I hugely appreciate this fix, I found it easiest to test simply by adding it to the PR I was working on where I had already moved this particular block to its own function. I worked great! At this point merging this PR would just cost me a slight amount more work dealing with the conflict it would create with my larger PR.

@chambm
Copy link
Member

chambm commented Nov 28, 2024 via email

@brendanx67
Copy link
Contributor

Still. It just seems like more work that simply closing this PR. It is just two lines and I had to put them in the right place in my branch to test them where I was seeing the problem most visibly. I will look into the kind of linked PR you are suggesting another time.

@brendanx67
Copy link
Contributor

This fix has been merged in PR#3247

@brendanx67 brendanx67 closed this Nov 28, 2024
@eduardo-proteinms eduardo-proteinms deleted the Skyline/work/20241127_InvestigateZedGraphTickBug branch January 23, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants