Mobilion reader uses HDF5 library, which isn't thread safe. Put a processwide lock in the ctor to ensure only one thread is in use at a time #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cesswide lock in the ctor to ensure only one thread is in use at a time
|
For the record, this is a design call made by MattC and myself, in anticipation of Mobilion resolving the issue eventually. Not worth the effort to build a "not suitable for parallel use" sense into the UI of either application. |
|
Eventually I should add an IterationListener parameter for Reader::read() so the user can be informed why it's paused. Could be useful for other readers as well if/when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks a bit funny when parallel processing multiple .mbi files in Skyline and MSConvertGUI, as only one proceeds at a time, but it does complete