Skyline: Cleanup persistent folder before and after test runs #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brendanx67
commented
Dec 6, 2024
brendanx67
commented
- Helps avoid the case where a prior failure causes an echo failure in the next run because cleanup deletes left over files in the persistent folder
- Helps avoid the case where a prior failure causes an echo failure in the next run because cleanup deletes left over files in the persistent folder
chambm
approved these changes
Dec 6, 2024
|
Yes. Feel free to add them. I am focusing on the 24 officially published
tutorials. Feeling like we need an indicator for whether a tutorial is
officially published as a lot has crept into the list that is not yet
officially published.
Though maybe that is already ending in Tutorial for officially published
and I just need to downgrade the tutorials that are not official to ending
in TutorialDraft
…On Fri, Dec 6, 2024 at 8:16 AM Matt Chambers ***@***.***> wrote:
***@***.**** approved this pull request.
It's great to make it more robust to failures. There are probably more
tests that need CleanupPersistentDir() overloads added though, right?
—
Reply to this email directly, view it on GitHub
<#3266 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYBWUF43OQAUX2RSWQV7GL2EHEUVAVCNFSM6AAAAABTDWKQNCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOBVGMYDKMJWGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
bspratt
reviewed
Dec 6, 2024
| @@ -1991,6 +1991,8 @@ private void runMode_SelectedIndexChanged(object sender, EventArgs e) | |||
| { | |||
| runLoops.Checked = true; | |||
| runLoopsCount.Text = 1.ToString(); | |||
| Offscreen.Checked = false; // Can't do screenshots offscreen | |||
There was a problem hiding this comment.
This doesn't appear to be re-enabled when the control is switched back to Test
There was a problem hiding this comment.
Probably want a behavior more like what you get when parallel mode is turned on/off
There was a problem hiding this comment.
Good catch. I think I fixed the potential inconsistencies the code was allowing before.
brendanx67
deleted the
Skyline/work/20241205_cleanup_persistent_cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.